On 26/02/2025 18:50, Sebastian LaVine wrote: > Hello Krzysztof, > > On Thu Feb 13, 2025 at 4:26 AM EST, Krzysztof Kozlowski wrote: >> On Wed, Feb 12, 2025 at 02:56:53PM -0500, Sebastian LaVine wrote: >>> Adds bindings for the Sony IMX728. >>> >>> Signed-off-by: Sebastian LaVine <slavine@xxxxxxxxxxxxxx> >>> Mentored-by: Stuart Burtner <sburtner@xxxxxxxxxxxxxx> >>> --- >> >> Please run scripts/checkpatch.pl and fix reported warnings. After that, >> run also 'scripts/checkpatch.pl --strict' and (probably) fix more >> warnings. Some warnings can be ignored, especially from --strict run, >> but the code here looks like it needs a fix. Feel free to get in touch >> if the warning is not clear. > > The only output I get from scripts/checkpatch.pl for this patch is the > following: > >> next$ scripts/checkpatch.pl --strict patches/outgoing/0001-media-dt-bindings-Add-Sony-IMX728.patch >> WARNING: Non-standard signature: Mentored-by: >> #9: >> Mentored-by: Stuart Burtner <sburtner@xxxxxxxxxxxxxx> >> >> total: 0 errors, 1 warnings, 0 checks, 108 lines checked >> >> ... > > I can change this to a Signed-off-by from Stuart if you would like, > though I feel that Mentored-by is applicable to this case. It has been two weeks, so I don't remember what warning I saw (countless of patches in between). It's possible I had in mind the "mentored-by", because it's nowhere explained in Linux. Does it mean part of DCO chain? Does it mean reviews or suggestions? This should be one of standard tags, IMO, with all its effects (because tags have meaning, e.g. DCO or reviewer's statement of oversight). Best regards, Krzysztof
