On Wed, Feb 26, 2025 at 05:25:06PM +0800, Bingbu Cao wrote: > >>>>> diff --git a/drivers/media/pci/intel/ipu6/ipu6-dma.h b/drivers/media/pci/intel/ipu6/ipu6-dma.h > >>>>> index b51244add9e6..2882850d9366 100644 > >>>>> --- a/drivers/media/pci/intel/ipu6/ipu6-dma.h > >>>>> +++ b/drivers/media/pci/intel/ipu6/ipu6-dma.h > >>>>> @@ -43,7 +43,4 @@ int ipu6_dma_map_sgtable(struct ipu6_bus_device *sys, struct sg_table *sgt, > >>>>> enum dma_data_direction dir, unsigned long attrs); > >>>>> void ipu6_dma_unmap_sgtable(struct ipu6_bus_device *sys, struct sg_table *sgt, > >>>>> enum dma_data_direction dir, unsigned long attrs); > >>>>> -int ipu6_dma_get_sgtable(struct ipu6_bus_device *sys, struct sg_table *sgt, > >>>>> - void *cpu_addr, dma_addr_t handle, size_t size, > >>>>> - unsigned long attrs); > >>>> > >>>> ipu6_dma_get_sgtable() is used in downstream PS driver, I don't think it > >>>> is necessary to remove it as it will be hard to integrate with downstream PS > >>>> driver. > >>> > >>> When will there be an upstream PSYS driver? > >>> > >>> I suppose you can just as well apply a revert of this patch to your > >>> downstream tree? > >>> > >> > >> Sakari, > >> > >> I don't think all the OS vendors like this way, it make the downstream > >> development harder. It's a trade-off, I cannot see removing offer any > >> benefits that its side-effect. > > > > I don't think the Linux distro maintainers like downstream drivers at all, > > independently of how many patches they consist of. > > > > You could as well move the function to the PSYS driver and use > > find_vm_area(cpu_addr) instead to find the area. > > My fault, I forgot I already removed the ipu6_dma_get_sgtable() from > downstream driver months ago, so, > > Reviewed-by: Bingbu Cao <bingbu.cao@xxxxxxxxx> Thanks, Bingbu! -- Sakari Ailus
