Hi Jacopo, Thanks for your work. On 2025-02-24 21:19:40 +0100, Jacopo Mondi wrote: > The IIF (ISP InterFace) is a VSP2 function that reads data from > external memory using two RPF instances and feed it to the ISP. > > The IIF support is modeled in the vsp1 driver as a new, simple, > entity type. > > IIF is part of VSPX, a version of the VSP2 IP specialized for ISP > interfacing. To prepare to support VSPX, support IIF first by > introducing a new entity and by adjusting the RPF/WPF drivers to > operate correctly when an IIF is present. > > Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@xxxxxxxxxxxxxxxx> > --- > Changes in v2: > - Collect tags > - Address review comments from Laurent, a lot of tiny changes here and > there but no major redesign worth an entry in the patchset changelog I'm still no expert on the VSP1 but the changes looks good, so FWIW. Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> I also tested this with the ISP and it all works as expected, Tested-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > --- > Jacopo Mondi (6): > media: vsp1: Add support IIF ISP Interface > media: vsp1: Clean FRE interrupt status > media: vsp1: dl: Use singleshot DL for VSPX > media: vsp1: rwpf: Break out format handling > media: vsp1: rwpf: Support RAW Bayer and ISP config > media: vsp1: rwpf: Support operations with IIF > > drivers/media/platform/renesas/vsp1/Makefile | 2 +- > drivers/media/platform/renesas/vsp1/vsp1.h | 3 + > drivers/media/platform/renesas/vsp1/vsp1_dl.c | 7 +- > drivers/media/platform/renesas/vsp1/vsp1_drv.c | 14 ++- > drivers/media/platform/renesas/vsp1/vsp1_entity.c | 8 ++ > drivers/media/platform/renesas/vsp1/vsp1_entity.h | 1 + > drivers/media/platform/renesas/vsp1/vsp1_iif.c | 133 ++++++++++++++++++++++ > drivers/media/platform/renesas/vsp1/vsp1_iif.h | 26 +++++ > drivers/media/platform/renesas/vsp1/vsp1_pipe.c | 1 + > drivers/media/platform/renesas/vsp1/vsp1_pipe.h | 1 + > drivers/media/platform/renesas/vsp1/vsp1_regs.h | 8 ++ > drivers/media/platform/renesas/vsp1/vsp1_rpf.c | 18 ++- > drivers/media/platform/renesas/vsp1/vsp1_rwpf.c | 110 ++++++++++++++++-- > drivers/media/platform/renesas/vsp1/vsp1_wpf.c | 14 ++- > 14 files changed, 327 insertions(+), 19 deletions(-) > --- > base-commit: b2c4bf0c102084e77ed1b12090d77a76469a6814 > change-id: 20250123-v4h-iif-a1dda640c95d > > Best regards, > -- > Jacopo Mondi <jacopo.mondi+renesas@xxxxxxxxxxxxxxxx> > -- Kind Regards, Niklas Söderlund
