Hi Shravan, On Mon, Feb 24, 2025 at 11:07:58AM +0000, Shravan.Chippa@xxxxxxxxxxxxx wrote: > > > > Please split this into two to make it more reviewable: splitting > > > > register lists into two and then to adding new modes. > > > > > > I will try to make one patch for common register values One more patch > > > for new modes of 640x480 and 1280x720 > > > > Please add one for the hblank changes and more if there are similar cases. > > Date sheet is not clear to me to understand the horizontal blank change value dynamically. > And do not have proper equipment (hardware) to measure horizontal blank values by change the register values. Ok, fair enough. Maybe it'd be better to leave it as-is if there's no need to change it? Many Omnivision sensors use some other, non-line/pixel based unit for blankings indeed. -- Regards, Sakari Ailus
