Hi Andy
> On 21 Feb 2025, at 9:21 PM, andriy.shevchenko@xxxxxxxxxxxxxxx wrote:
>
> On Fri, Feb 21, 2025 at 11:36:00AM +0000, Aditya Garg wrote:
>> From: Kerem Karabay <kekrby@xxxxxxxxx>
>>
>> Add XRGB8888 emulation helper for devices that only support BGR888.
>
> ...
>
>> + for (x = 0; x < pixels; x++) {
>> + pix = le32_to_cpu(sbuf32[x]);
>> + /* write red-green-blue to output in little endianness */
>> + *dbuf8++ = (pix & 0x00ff0000) >> 16;
>> + *dbuf8++ = (pix & 0x0000ff00) >> 8;
>> + *dbuf8++ = (pix & 0x000000ff) >> 0;
>
> put_unaligned_be24()
>
>> + }
>
> ...
>
>> + static const u8 dst_pixsize[DRM_FORMAT_MAX_PLANES] = {
>> + 3,
>> + };
>
> One line?
>
> static const u8 dst_pixsize[DRM_FORMAT_MAX_PLANES] = { 3 };
Wrt all the above respective changes, the formatting has been done exactly like what other emulation helps do in the upstream patch.
I doubt Thomas would want these changes to be done, or would want these changes to be done for the upstream emulation helpers as well.
For reference: https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/drm_format_helper.c
Regards
Aditya
