Re: [RFC, PATCH] Add 10 bit packed greyscale format.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 16 Dec 2010 12:29:44 +0100
Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx> wrote:

> A 10 bits per pixel greyscale format in a packed array representation is
> supplied for instance by Kinect sensor device.
> 
> Signed-off-by: Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx>
> ---
>

Ping.

> Hi,
> 
> This is the first attempt to add v4l support for the 10bpp packed array format
> used by the Kinect sensor device for depth data and for IR mode (in this mode
> the device streams the image as seen by the monochrome sensor).
> 
> This version is mainly to start the discussion about the format and how it
> should be seen by v4l, the doubts I still have are about:
> 
>   1. The name of the format: is Y10P OK? Moreover, "packed" here is used in a
>      _stronger_ meaning compared to the other packed formats, and I also saw the
>      name "compact array" used somewhere for these kind of objects.
> 
>   2. The actual order of the bits, please check the documentation below to see
>      if I got it right.
>      And maybe I should not mention the unpacked version of the data as this
>      depends on the unpacking algorithm, what do you think?
>

Ok, I checked that the order of the bits in the packed representation
used on the kinect is the natural one (most significant bits come
first from the left). And about the unpacking, well, if we called this
format Y10P, are we implying that the unpacked format is Y10, hence
with little-endian order? Or should we consider the two formats
independent even if the names are so similar?

>   3. The way to illustrate the packed array concept in the documentation: I
>      used a bit-field syntax like in hardware registers docs, does this look
>      meaningful to you? Or should I find a way to clearly show the difference
>      between _byte_alignment_ and _element_alignment_.
>

Now that I've checked the actual data format I am dealing with, I think
I can improve the illustration as well.

> If you could point to some literature about packed array representations I'd be
> happy to take a look at it.
> 
> After these issues are addressed, I am going to submit changes to libv4l as
> well.
> 
> Thanks,
>   Antonio Ospite
>   http://ao2.it
> 
[...]

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

Attachment: pgptQ5kRuzl6L.pgp
Description: PGP signature


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux