On Mon, 2025-02-17 at 02:11 +0000, Jammy Huang wrote: > Hi Andrew, > > Thanks for your feedback, please find my explanation below. > > > > > On Thu, 2025-02-13 at 09:53 +0800, Jammy Huang wrote: > > > Convert aspeed-video.txt to yaml format. > > > Update aspeed-video.txt to aspeed,video-engine.yaml in MAINTAINER file. > > > > > > Signed-off-by: Jammy Huang <jammy_huang@xxxxxxxxxxxxxx> > > > ... > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - clocks > > > + - clock-names > > > + - interrupts > > > > This should list `resets` as well, as that wasn't optional in the text binding. > > > 'resets' is not listed as required here is because ASPEED handle reset in the clock driver > in ast2600/ast2500/..., etc. So I keep this part identical as previous aspeed-video.txt. It's not identical though. The text binding listed the _optional_ properties, while the yaml binding lists the _required_ properties. The reset property appears in neither list across two binding definitions, but it has to be in one or the other for consistency. However, it sounds like the text binding was not accurate, and this is reflected in the video nodes in the SoC DTSIs. The yaml binding definition at least matches that reality. Andrew
