On Tue, Feb 11, 2025 at 05:31:06PM +0100, Christian König wrote:
> There isn't much worse than documentation giving an incorrect advise.
> Grabbing a spinlock while interrupts are disabled usually means that you
> must also disable interrupts for all other uses of this spinlock.
>
> Otherwise really hard to debug issues can occur. So fix that invalid
> documentation.
>
> Signed-off-by: Christian König <christian.koenig@xxxxxxx>
Oops :-/
Reviewed-by: Simona Vetter <simona.vetter@xxxxxxxx>
> ---
> include/linux/dma-fence.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
> index e7ad819962e3..e230af0d123f 100644
> --- a/include/linux/dma-fence.h
> +++ b/include/linux/dma-fence.h
> @@ -169,8 +169,8 @@ struct dma_fence_ops {
> * implementation know that there is another driver waiting on the
> * signal (ie. hw->sw case).
> *
> - * This function can be called from atomic context, but not
> - * from irq context, so normal spinlocks can be used.
> + * This is called with irq's disabled, so only spinlocks which also
> + * disable irq's can be used.
> *
> * A return value of false indicates the fence already passed,
> * or some failure occurred that made it impossible to enable
> --
> 2.34.1
>
--
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
