Hello Dikshita Agarwal,
Commit fb583a214337 ("media: iris: introduce host firmware interface
with necessary hooks") from Feb 7, 2025 (linux-next), leads to the
following Smatch static checker warning:
drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c:878 iris_hfi_gen2_handle_response()
error: NULL dereference inside function iris_hfi_gen2_handle_system_error()
drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c
871 static int iris_hfi_gen2_handle_response(struct iris_core *core, void *response)
872 {
873 struct iris_hfi_header *hdr = (struct iris_hfi_header *)response;
874 int ret;
875
876 ret = iris_hfi_gen2_validate_hdr_packet(core, hdr);
877 if (ret)
--> 878 return iris_hfi_gen2_handle_system_error(core, NULL);
^^^^
This will lead to a NULL dereference
879
880 if (!hdr->session_id)
881 return iris_hfi_gen2_handle_system_response(core, hdr);
882 else
883 return iris_hfi_gen2_handle_session_response(core, hdr);
884 }
regards,
dan carpenter
