Re: [PATCH v7] media: i2c: Add Omnivision OV02C10 sensor driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Wed, Jan 22, 2025 at 08:32:49AM +0000, Sakari Ailus wrote:
> > +	/* Check HW config */
> > +	ret = ov02c10_check_hwcfg(&client->dev, ov02c10);
> > +	if (ret) {
> > +		dev_err(&client->dev, "failed to check hwcfg: %d", ret);
> > +		return ret;
> > +	}
> > +
> > +	v4l2_i2c_subdev_init(&ov02c10->sd, client, &ov02c10_subdev_ops);
> > +	ov02c10_get_pm_resources(&client->dev);
> 
> Error handling is missing.

It is fine since we can work without pm/gpio's on setups where iVSC
control powering of the sensor. Maybe comment about that could be added.

Regards
Stanislaw




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux