Hi, I was doing an audit and I came across this. drivers/media/video/cx231xx/cx231xx-core.c +1644 cx231xx_write_i2c_data(14) warn: 'saddr_len' is non-zero. Did you mean 'saddr' 1642 if (saddr_len == 0) 1643 saddr = 0; 1644 else if (saddr_len == 0) 1645 saddr &= 0xff; We check "saddr_len == 0" twice which doesn't make sense. I'm not sure what the correct fix is though. It's been this way since the driver was merged. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html