RE: [PATCH 02/13] v4l: Add multi-planar ioctl handling code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Wednesday, December 22, 2010 9:39 PM Hans Verkuil wrote:

> On Wednesday, December 22, 2010 18:10:26 Pawel Osciak wrote:
> > From: Pawel Osciak <p.osciak@xxxxxxxxxxx>
> >
> > Add multi-planar API core ioctl handling and conversion functions.
> >
> > Signed-off-by: Pawel Osciak <p.osciak@xxxxxxxxxxx>
> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > Reviewed-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> > ---
> >  drivers/media/video/v4l2-ioctl.c |  453 ++++++++++++++++++++++++++++++++++----
> >  include/media/v4l2-ioctl.h       |   16 ++
> >  2 files changed, 425 insertions(+), 44 deletions(-)
> >
> > diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
> > index 8516669..e2f6abb 100644
> > --- a/drivers/media/video/v4l2-ioctl.c
> > +++ b/drivers/media/video/v4l2-ioctl.c
> 
> <snip>
> 
> OK, looks good.
> 
> Marek, this patch + the other patches from your v8 patch series are good to
> go as far as I am concerned. So you can add my tag to the whole series:
> 
> Reviewed-by: Hans Verkuil <hverkuil@xxxxxxxxx>
> 
> The only note I want to make is that the V4L2 DocBook spec needs to be updated
> for the multiplanar API. But in my opinion that patch can be done in January.

Thanks for your review and help! I've uploaded a new version with your tag to:
git://git.infradead.org/users/kmpark/linux-2.6-samsung vb2 branch.
You can quickly access it here:
http://git.infradead.org/users/kmpark/linux-2.6-samsung/shortlog/refs/heads/vb2
(it should be available in a few hours).

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux