On Tue, Jan 14, 2025 at 11:20:30PM +0800, Ricardo Ribalda wrote: > On Tue, 14 Jan 2025 at 20:41, Thadeu Lima de Souza Cascardo > <cascardo@xxxxxxxxxx> wrote: [...] > Please correct me if I am wrong, but the ID is only required to > configure the topology of the device. If multiple entities have the > same id then they cannot be part of the topology, because we will > never be sure about what entity is the correct one. > I can say mostly about the device that has been reported: Output Terminal has ID 5 and source ID 4. Processing Unit has ID 5 and source ID 4. Input Terminal has ID 1. But we end up connecting them with uvc_scan_fallback: OT -> PU -> IT As if Processing Unit had ID 4 and source ID 1. > My proposal is to mark the duplicated as invalid so they cannot be > found with uvc_entity_by_id(), but they can still have controls. > I would need to test them. > I think it can work with multiple duplicated IDs. It is also pretty > clean and is not affected by the issue found by syszcaller. > > In any case we probably want to act fast on this one. We had reports > from multiple parties. > Perhaps we should then revert the previous fix (which implies that this same device would lead to some warnings, but they don't seem to cause any other issues except for not exposing some media controls). And, then, we work on reapplying it and another fix on top, or a different fix during 6.14 or 6.15. Thanks for the patience. Cascardo. > Regards!
