On Fri, Jan 10, 2025 at 11:14:17AM +0200, Tomi Valkeinen wrote: > From: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx> > > The serializer's I2C address on the FPD-Link bus is usually communicated > to the deserializer once the forward-channel is established. But in some > cases it might be necessary to program the serializer (over the > back-channel) before the forward-channel is established. > > This can be used e.g. to correct serializer configuration which > otherwise would prevent the FC to be enabled. > > Add a new optional property to specify the I2C address of the > serializer. > > Signed-off-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: Rob Herring <robh@xxxxxxxxxx> > Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx> Why only these folks? Why not all of the maintainers? Anyway, Please drop the autogenerated scripts/get_maintainer.pl CC-entries from commit msg. There is no single need to store automated output of get_maintainers.pl in the git log. It can be easily re-created at any given time, thus its presence in the git history is redundant and obfuscates the log. If you need it for your own patch management purposes, keep it under the --- separator. > --- > Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml > index 0b71e6f911a8..e17b508b6409 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml > @@ -75,6 +75,13 @@ properties: > address on the I2C bus where the deserializer resides are > forwarded to the serializer. > > + i2c-addr: > + $ref: /schemas/types.yaml#/definitions/uint32 Why isn't this part of reg, if that's the same device? If that is not the same device, you are not expected to encode addresses of other devices in this device. Address of 'foo' is not a property of device 'bar'. Phandles or graphs express relationships between devices. Best regards, Krzysztof
