On 06/01/2025 13:40, Ricardo Ribalda wrote:
The driver uses "whole" fps in all its calculations (e.g. in
load_per_instance()). Return -EINVAL if the user provides a parm that
will result in 0 whole fps.
Reported-by: Hans Verkuil <hverkuil@xxxxxxxxx>
Closes: https://lore.kernel.org/linux-media/f11653a7-bc49-48cd-9cdb-1659147453e4@xxxxxxxxx/T/#m91cd962ac942834654f94c92206e2f85ff7d97f0
Fixes: aaaa93eda64b ("[media] media: venus: venc: add video encoder files")
Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
---
drivers/media/platform/qcom/venus/venc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
index c1c543535aaf..bd967d60c883 100644
--- a/drivers/media/platform/qcom/venus/venc.c
+++ b/drivers/media/platform/qcom/venus/venc.c
@@ -411,7 +411,7 @@ static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)
us_per_frame = timeperframe->numerator * (u64)USEC_PER_SEC;
do_div(us_per_frame, timeperframe->denominator);
- if (!us_per_frame)
+ if (!us_per_frame || us_per_frame > USEC_PER_SEC)
return -EINVAL;
fps = (u64)USEC_PER_SEC;
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
