Hello Sakari, Geert, As discussed in the series which added line-orders support [1] the method which line-orders are parsed differers from how bus-type is parsed. The line-order parsing skipped an intermediary step which aids in separating the values used in device tree sources and the values used by drivers. This was done to keep the line-order simple and based on the fact that compared to bus-types we are unlikely to get any more line order settings, at least not for CSI-2 C-PHY. But as Geert pointed it out this series addresses this and moves the line-orders parsing to use the same intermediary step as bus-type. We also gain an enum for the line orders at the fwnode level which may or may not be use-full down the line which we previously did not have. As an added bonus the parsing code is a tad easier to read as the parsing function is already quiet large and the new helper functions to match how bus-type is parsed reduces that a bit. Patch 1/2 adds the missing intermediary enum, while patch 2/2 breaks out the line-order parsing into helper functions and a struct to record the information. All of this mimics the pattern used for bus-type pattern. There is no intentional functional change in this series and it have been tested on Renesas devices. 1. [PATCH v2 0/4] media: v4l: fwnode: Add support for CSI-2 C-PHY line orders Niklas Söderlund (2): media: v4l: fwnode: Add definitions for CSI-2 C-PHY line-orders media: v4l: fwnode: Parse CSI-2 C-PHY line-orders like bus-type drivers/media/v4l2-core/v4l2-fwnode.c | 80 ++++++++++++++++++++++----- include/media/v4l2-fwnode.h | 18 ++++++ 2 files changed, 84 insertions(+), 14 deletions(-) -- 2.47.1
