Hi Ishikawa-san, Thank you for the patch. On Mon, Nov 25, 2024 at 06:21:46PM +0900, Yuji Ishikawa wrote: > Added entries for visconti Video Input Interface driver, including; Commit messages are written using the imperative mood, as if you were giving orders to someone: s/Added/Add/ > * device tree bindings > * source files > * documentation files > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@xxxxxxxxxxxxx> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> I would have added the MAINTAINERS entry in 1/8 with just the DT binding file, and added more files in corresponding patches. That would be easier to review and check if entries are missing. I don't mind much though, so if you prefer keeping it this way: Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > Changelog v2: > - no change > > Changelog v3: > - added entry for driver API documentation > > Changelog v4: > - added entry for header file > > Changelog v5: > - no change > > Changelog v6: > - update path to VIIF driver source files > > Changelog v7: > - no change > > Changelog v8: > - rename bindings description file > > Changelog v9: > - no change > > Changelog v10: > - add a separate entry of VIIF driver > > Changelog v11: > - no change > > Changelog v12: > - add a bindings description of CSI2RX driver > > MAINTAINERS | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b878ddc99f94..b5c819e94e9b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -23430,6 +23430,18 @@ F: Documentation/devicetree/bindings/media/i2c/tc358743.txt > F: drivers/media/i2c/tc358743* > F: include/media/i2c/tc358743.h > > +TOSHIBA VISCONTI VIIF DRIVER > +M: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > +M: Yuji Ishikawa <yuji2.ishikawa@xxxxxxxxxxxxx> > +L: linux-media@xxxxxxxxxxxxxxx > +S: Maintained > +F: Documentation/admin-guide/media/visconti-viif.* > +F: Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml > +F: Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yaml > +F: Documentation/userspace-api/media/v4l/metafmt-visconti-viif.rst > +F: drivers/media/platform/toshiba/visconti/ > +F: include/uapi/linux/visconti_viif.h > + > TOSHIBA WMI HOTKEYS DRIVER > M: Azael Avalos <coproscefalo@xxxxxxxxx> > L: platform-driver-x86@xxxxxxxxxxxxxxx -- Regards, Laurent Pinchart
