Hi, Krzysztof: On Tue, 2024-12-31 at 08:45 +0100, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > On 27/12/2024 07:05, CK Hu (胡俊光) wrote: > > On Wed, 2024-12-25 at 17:00 +0800, bo.kong wrote: > > > From: Bo Kong <Bo.Kong@xxxxxxxxxxxx> > > > > > > Add a V4L2 sub-device driver for MT8188 AIE. > > > > > > Signed-off-by: Bo Kong <Bo.Kong@xxxxxxxxxxxx> > > > --- > > > > [snip] > > > > > +static void aie_reset_output_buf(struct mtk_aie_dev *fd, > > > + struct aie_enq_info *aie_cfg) > > > +{ > > > > Why clear output buffer? > > Could you point out which place in the output buffer that hardware does not write data into but software would read it? > > > Please respond with one email doing review, not 10 per each comment. Sorry to bother you. I would try to respond in one email. Even though I have new comment when second review, I would not respond so frequently. regards, CK > > Best regards, > Krzysztof