Re: [PATCH 08/16] media: qcom: camss: vfe: Move common code into vfe core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vladimir, Bryan,

On 12/12/2024 3:57 PM, Vladimir Zapolskiy wrote:
On 12/12/24 03:35, Bryan O'Donoghue wrote:
On 12/12/2024 01:06, Vladimir Zapolskiy wrote:

This is a massive and a functional change

It shouldn't be a _functional_ change at all, just a refactoring and a
reduction.

I've just tested that this change breaks not only TPG on SM8250/RB5, but
a regular image capturing from imx577 camera sensor is also broken.

Hope it helps.


I will remove a modification to update the enable_irq order in this patch which is asked by Bryan in v4 patches [1] and make sure there is no logical change between old code and new refactor code, in case any regression in this change.

I'll take a look too, see if I can spot a regression on rb3-gen1 and
replicate the breakage on rb5.


Thank you, very much appreciated. Splitting the change would be still
welcome.

@Depeng we can probably get you remote access to an RB5 if you need it.



[1] https://lore.kernel.org/all/47aa934d-bdad-4c76-9420-ce65950f67d1@xxxxxxxxxx/

Thanks,
Depeng





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux