On Fri, 20 Dec 2024 at 16:21, Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> wrote: > > From: John Cox <john.cox@xxxxxxxxxxxxxxx> > > The BCM2711 and BCM2712 SoCs used on Rapsberry Pi 4 and Raspberry > Pi 5 boards include an HEVC decoder block. Add a driver for it. > > Signed-off-by: John Cox <john.cox@xxxxxxxxxxxxxxx> > Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > --- > MAINTAINERS | 10 + > drivers/media/platform/raspberrypi/Kconfig | 1 + > drivers/media/platform/raspberrypi/Makefile | 1 + > .../media/platform/raspberrypi/hevc_dec/Kconfig | 17 + > .../media/platform/raspberrypi/hevc_dec/Makefile | 5 + > .../media/platform/raspberrypi/hevc_dec/hevc_d.c | 443 ++++ > .../media/platform/raspberrypi/hevc_dec/hevc_d.h | 190 ++ > .../platform/raspberrypi/hevc_dec/hevc_d_h265.c | 2629 ++++++++++++++++++++ > .../platform/raspberrypi/hevc_dec/hevc_d_hw.c | 376 +++ > .../platform/raspberrypi/hevc_dec/hevc_d_hw.h | 303 +++ > .../platform/raspberrypi/hevc_dec/hevc_d_video.c | 685 +++++ > .../platform/raspberrypi/hevc_dec/hevc_d_video.h | 38 + > 12 files changed, 4698 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index a33a97d5ffff..569b478c44fe 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19567,6 +19567,16 @@ L: linux-edac@xxxxxxxxxxxxxxx > S: Maintained > F: drivers/ras/amd/fmpm.c > <snip> Typical. You read a patch multiple times over, and still miss a "git add" of a new file I won't send a new version now as there are bound to be multiple other things in review, but hevc_d_h265.h should read // SPDX-License-Identifier: GPL-2.0-or-later /* * Raspberry Pi HEVC driver * * Copyright (C) 2024 Raspberry Pi Ltd * */ #ifndef _HEVC_D_H265_H_ #define _HEVC_D_H265_H_ #include "hevc_d.h" extern const struct v4l2_ctrl_ops hevc_d_hevc_sps_ctrl_ops; extern const struct v4l2_ctrl_ops hevc_d_hevc_pps_ctrl_ops; void hevc_d_h265_setup(struct hevc_d_ctx *ctx, struct hevc_d_run *run); int hevc_d_h265_start(struct hevc_d_ctx *ctx); void hevc_d_h265_stop(struct hevc_d_ctx *ctx); void hevc_d_h265_trigger(struct hevc_d_ctx *ctx); void hevc_d_device_run(void *priv); #endif Thanks Dave
