Hi, On 20-Dec-24 2:51 PM, Bryan O'Donoghue wrote: > On 20/12/2024 13:47, Hans de Goede wrote: >>>> } >>>> +static DEFINE_RUNTIME_DEV_PM_OPS(ov08x40_pm_ops, ov08x40_power_on, >>>> + ov08x40_power_off, NULL); >>>> + >> Ugh I have on/off swapped here, second argument of the macro is the suspend >> function so that should be ov08x40_power_off. IOW this should be: >> >> static DEFINE_RUNTIME_DEV_PM_OPS(ov08x40_pm_ops, ov08x40_power_off, >> ov08x40_power_on, NULL); >> >> Can you give this a try with that change? >> >> Regards, >> >> Hans > > Heh. > > That'd do it, works now. Great, thank you for testing! This probably also explains why this series did not help to get the sensor powered on on some x86 HP laptops... I guess you are going to test the rest of the series and then provided a Tested-by? If yes then I'll wait with posting v2 until you're done testing. Regards, Hans
