Hi Laurentiu, Thanks for your work. On 2024-12-20 12:49:37 +0200, Laurentiu Palcu wrote: > The current implementation has the register disabled since it is not > documented in the MAX96724 RM. However, in the chip's user's guide [1], > in the Video Pattern Generator section, the register is documented and > it appears to work just fine. Before the change I was experiencing > approx 10fps when streaming, after: 30.3fps. > > Hence, since both max96712 and max96724 have the register, we can remove > the flag. > > [1] https://www.analog.com/media/en/technical-documentation/user-guides/max96724fr-user-guide.pdf > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > v2: > * addressed Niklas' comments and removed the extra debug register flag; > > drivers/staging/media/max96712/max96712.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c > index 5228f9ec60859..ed4d5db1ff8d1 100644 > --- a/drivers/staging/media/max96712/max96712.c > +++ b/drivers/staging/media/max96712/max96712.c > @@ -27,7 +27,6 @@ enum max96712_pattern { > > struct max96712_info { > unsigned int dpllfreq; > - bool have_debug_extra; > }; > > struct max96712_priv { > @@ -174,9 +173,7 @@ static void max96712_pattern_enable(struct max96712_priv *priv, bool enable) > return; > } > > - /* Set PCLK to 75MHz if device have DEBUG_EXTRA register. */ > - if (priv->info->have_debug_extra) > - max96712_write(priv, DEBUG_EXTRA_REG, DEBUG_EXTRA_PCLK_75MHZ); > + max96712_write(priv, DEBUG_EXTRA_REG, DEBUG_EXTRA_PCLK_75MHZ); > > /* Configure Video Timing Generator for 1920x1080 @ 30 fps. */ > max96712_write_bulk_value(priv, 0x1052, 0, 3); > @@ -457,7 +454,6 @@ static void max96712_remove(struct i2c_client *client) > > static const struct max96712_info max96712_info_max96712 = { > .dpllfreq = 1000, > - .have_debug_extra = true, > }; > > static const struct max96712_info max96712_info_max96724 = { > -- > 2.34.1 > -- Kind Regards, Niklas Söderlund
