Em Wed, 18 Dec 2024 04:18:47 +0200
Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> escreveu:
> On Tue, Dec 17, 2024 at 05:54:08PM -0800, Patchwork Integration wrote:
> > Dear Laurent Pinchart:
> >
> > Thanks for your patches! Unfortunately media-ci detected some issues:
> >
> > # Test media-patchstyle:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch media style
> > WARNING: Commit cf21f328fcafacf4f96e7a30ef9dceede1076378 found in the stable tree, but stable@xxxxxxxxxxxxxxx not in Cc:
> > WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")'
> > #16:
> > Fixes: cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver")
>
> I don't think Cc: stable makes sense for this particular commit.
Sure, not all commits are actually fixing things, but, in this
particular case, it sounds that it contains a real problem:
Running the v4l2-compliance (1.27.0-5208, SHA: af114250d48d) on the m2m
device fails on the MMAP streaming tests, with the following messages:
fail: v4l2-test-buffers.cpp(240): g_field() == V4L2_FIELD_ANY
fail: v4l2-test-buffers.cpp(1508): buf.qbuf(node)
causing userspace to fail. For me, it seems that such patch needs to
be backported.
In doubt, please add c/c stable when fixes is used. If there are good
reasons why not doing it, please place the rationale at the patch.
> > total: 0 errors, 1 warnings, 15 lines checked
> > WARNING: ./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch: Fails some mandatory checkpatch tests
> >
> > # Test checkpatch:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch checkpatch
> > WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")'
> > #16:
> > Fixes: cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver")
> >
> > total: 0 errors, 1 warnings, 0 checks, 15 lines checked
>
> This I can fix. I'll wait for replies to the above though.
Please do it.
The rest of the PR sounds OK on my eyes.
Thanks,
Mauro
