Re: [PATCH v5 3/4] arm64: dts: qcom: qcs615: add venus node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 12/17/2024 8:09 PM, Dmitry Baryshkov wrote:
On Tue, Dec 17, 2024 at 05:54:57PM +0800, Renjiang Han wrote:
On 12/17/2024 5:38 PM, Bryan O'Donoghue wrote:
On 17/12/2024 09:17, Renjiang Han wrote:
+
+            video-decoder {
+                compatible = "venus-decoder";
+            };
+
+            video-encoder {
+                compatible = "venus-encoder";
+            };
I gave you feedback on this in v4.

Could you please provide some commentary on why you're persisting with
this ?

- Driver configuration should not live in dts
- A patchset exists to mitigate this
- If you don't want to use that series, what do you propose
   to resolve this ?

Please don't just ignore feedback, either act on it or add to your
commit log _why_ you didn't act on it.

---
bod
  Thanks for your review. You pointed it out correctly. As replied in v4,

  I also think your change is a good change, but your change involves many

  platforms.
You can help it by reviewing it and then providing a Tested-by tag for
it.
OK. I'll try it.

P.S. Something is wrong with your emails, I see a lot of lines separated
by empty lines. It makes it harder to read.

Thanks for your reminder. I'll check my environment.

--
Best Regards,
Renjiang





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux