On 17/12/2024 15:06, Vikram Sharma wrote: > This patch changes gcc_cam_hf_axi clock name to make consistent Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > with existing platforms and add gcc_axi_sf clock too. > gcc_cam_hf_axi changed to gcc_axi_hf. > added gcc_axi_sf. Explain ABI impact and don't mix new features with some sort of refactoring. > > Signed-off-by: Vikram Sharma <quic_vikramsa@xxxxxxxxxxx> > --- > drivers/media/platform/qcom/camss/camss.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index 004a74f6b2f6..1d992dc74877 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -1443,12 +1443,13 @@ static const struct camss_subdev_resources vfe_res_7280[] = { > .regulators = {}, > > .clock = { "camnoc_axi", "cpas_ahb", "icp_ahb", "vfe0", > - "vfe0_axi", "gcc_cam_hf_axi" }, > + "vfe0_axi", "gcc_axi_hf", "gcc_axi_sf" }, I don't get how this works with old DTS. This looks like pure ABI break without any explanation. Best regards, Krzysztof
