Hi,
Le mardi 17 décembre 2024 à 13:51 +0900, Jackson.lee a écrit :
> When a decoder instance is created, W5_CMD_ERR_CONCEAL register should be
> initialized to 0. If not set to 0, gray color can occasionally be displayed
> on screen while decoding.
>
> Signed-off-by: Jackson.lee <jackson.lee@xxxxxxxxxxxxxxx>
> Signed-off-by: Nas Chung <nas.chung@xxxxxxxxxxxxxxx>
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>
You forgot to add Fixes: tags, can you find back which commit you fix, and send
us the correctly formatted tag ? This will avoid the need of a resend.
Nicolas
> ---
> drivers/media/platform/chips-media/wave5/wave5-hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
> index c8a905994109..d94cf84c3ee5 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
> @@ -585,7 +585,7 @@ int wave5_vpu_build_up_dec_param(struct vpu_instance *inst,
> vpu_write_reg(inst->dev, W5_CMD_NUM_CQ_DEPTH_M1,
> WAVE521_COMMAND_QUEUE_DEPTH - 1);
> }
> -
> + vpu_write_reg(inst->dev, W5_CMD_ERR_CONCEAL, 0);
> ret = send_firmware_command(inst, W5_CREATE_INSTANCE, true, NULL, NULL);
> if (ret) {
> wave5_vdi_free_dma_memory(vpu_dev, &p_dec_info->vb_work);
