On Mon, Dec 16, 2024 at 05:30:24PM -0500, Richard Acayan wrote: > The camera subsystem for the SDM670 the same as on SDM845 except with > 3 CSIPHY ports instead of 4. Add support for the SDM670 camera > subsystem. > > Signed-off-by: Richard Acayan <mailingradian@xxxxxxxxx> > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > Acked-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx> > --- > .../bindings/media/qcom,sdm670-camss.yaml | 72 +++---- > drivers/media/platform/qcom/camss/camss.c | 191 ++++++++++++++++++ You cannot combine such changes. Bindings are always separate. Please run scripts/checkpatch.pl and fix reported warnings. Then please run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Please drop the review/ack tags and request re-review for this patch. Best regards, Krzysztof
