Hello Krzysztof Thank you for your review > -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: Monday, November 25, 2024 7:11 PM > To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) > <yuji2.ishikawa@xxxxxxxxxxxxx>; Laurent Pinchart > <laurent.pinchart@xxxxxxxxxxxxxxxx>; Mauro Carvalho Chehab > <mchehab@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski > <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Sakari Ailus > <sakari.ailus@xxxxxxxxxxxxxxx>; Hans Verkuil <hverkuil-cisco@xxxxxxxxx>; > iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ) > <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v12 1/8] dt-bindings: media: platform: visconti: Add > Toshiba Visconti MIPI CSI-2 Receiver > > On 25/11/2024 10:21, Yuji Ishikawa wrote: > > Adds the Device Tree binding documentation that allows to describe the > > MIPI CSI-2 Receiver found in Toshiba Visconti SoCs. > > > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@xxxxxxxxxxxxx> > > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > > > How newly added patch can have already Rb tag? Was this review really, really > performed internally or you just satisfy some internal managers requirements > and fake the stats? > I added this Reviewed-by tag because the patch was reviewed internally. > > --- > > > > Changelog v12: > > - Newly add bindings for CSI2RX driver > > > > .../media/toshiba,visconti5-csi2rx.yaml | 104 > ++++++++++++++++++ > > 1 file changed, 104 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yam > > l > > b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yam > > l > > new file mode 100644 > > index 000000000000..5488072bc82a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx > > +++ .yaml > > @@ -0,0 +1,104 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +http://devicetree.org/schemas/media/toshiba,visconti5-csi2rx.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Toshiba Visconti5 SoC MIPI CSI-2 receiver > > + > > +maintainers: > > + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > > + > > +description: |- > > Drop |- > I'll drop "|-" > > + Toshiba Visconti5 SoC MIPI CSI-2 receiver device receives MIPI > > + CSI-2 video stream. Use with VIIF device. T.B.D > > + > > +properties: > > + compatible: > > + const: toshiba,visconti5-csi2rx > > Why this is called "RX"? Can you have a TX? I had impression that one cannot. > VIIF has only MIPI CSI2 receiver (CSI2RX). There's no TX for it. Visconti also has VOIF (Video Output Interface) hardware which has MIPI CSI2 (not DSI) transmitter (CSI2TX). > > + > > + reg: > > + items: > > + - description: Registers for CSI2 receiver control > > + > > + interrupts: > > + items: > > + - description: CSI2 Receiver Interrupt > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: > > + Input port node, single endpoint describing the CSI-2 > transmitter. > > + > > + properties: > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + description: CSI2 receiver supports 1, 2, 3 or 4 data lanes > > + minItems: 1 > > + items: > > + - const: 1 > > + - const: 2 > > + - const: 3 > > + - const: 4 > > + required: > > + - data-lanes > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Output port node, single endpoint describing the Visconti VIIF. > > + > > + required: > > + - port@0 > > + - port@1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - ports > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/interrupt-controller/irq.h> > > + > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + csi2rx@1c008000 { > > > csi@ > > Node names should be generic. See also an explanation and list of examples > (not exhaustive) in DT specification: > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetre > e-basics.html#generic-names-recommendation > I'll fix the node names. > > Best regards, > Krzysztof Best regards, Yuji Ishikawa
