Re: [PATCH v7 5/5] media: intel/ipu6: Obtain link frequency from a sub-device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 16, 2024 at 08:03:08AM +0000, Sakari Ailus wrote:
> On Sun, Dec 15, 2024 at 07:08:32PM +0200, Laurent Pinchart wrote:
> > Hi Sakari,
> > 
> > Thank you for the patch.
> > 
> > I think this should come before 4/5.
> 
> Because of...? Both are needed for this to work.

Because, unless I'm mistaken, it would otherwise introduce a bisection
breakage. 4/5 drops the LINK_FREQ control from the IVSC driver, and
obtaining the link frequency through .get_mbus_config() is only
supported when using the v4l2_get_link_freq() variant that takes a pad
argument.

> > On Tue, Dec 10, 2024 at 09:59:06AM +0200, Sakari Ailus wrote:
> > > Obtain the link frequency from the sub-device instead of a control
> > > handler. This allows obtaining it using the get_mbus_config() sub-device
> > > pad op that which is only supported by the IVSC driver.
> > 
> > "which is the only method supported by the IVSC driver"
> 
> Yes.

-- 
Regards,

Laurent Pinchart




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux