On 14/12/2024 00:29, Johnny Liu wrote: >> On Tue, Dec 10, 2024 at 09:45:50AM -0800, Johnny Liu wrote: >>> An activity monitor (actmon) is used to measure the device runtime >>> utilization to help drive software power management policies. >>> >>> Extend the reg space to include actmon aperture for actmon configuration >>> through host1x. >> >> We kind of see that from the diff. Say what we do not see, e.g. ABI >> impact or why this is flexible/optional for existing devices. > > Since actmon is not well-supported for the previous chips (e.g. T210, > T186, T194, and etc) in this patch series, it's essential to make the > specification of regs property optional for the previous chips. Then your schema should express it. > > Enablement/Disablement of actmon won't affect the host1x main functionality. > Its main job is to monitor the engines behind the host1x and serve for > telemetry purpose. > > I could update the commit message to include the above reason. Please > let me know if more information is required. And fix the schema to make it optional only for older variants. Best regards, Krzysztof
