Re: [PATCH v2 2/4] media: v4l: fwnode: Parse MiPI DisCo for C-PHY line-orders

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hej Sakari,

Tack för att du tog dig tid och tittade på detta.

On 2024-12-12 07:25:38 +0000, Sakari Ailus wrote:
> > @@ -250,6 +261,36 @@ static int 
> > v4l2_fwnode_endpoint_parse_csi2_bus(struct fwnode_handle *fwnode,
> >  		} else {
> >  			pr_debug("no lane polarities defined, assuming not inverted\n");
> >  		}
> > +
> > +		if (have_line_orders) {
> > +			fwnode_property_read_u32_array(fwnode,
> > +						       "line-orders", array,
> > +						       num_data_lanes);
> > +
> > +			for (i = 0; i < num_data_lanes; i++) {
> > +				static const char * const orders[] = {
> > +					"ABC", "ACB", "BAC", "BCA", "CAB", "CBA"
> > +				};
> > +
> > +				if (array[i] > 5) {
> 
> 
> I'd use:
> 
> 				if (... >= ARRAY_SIZE(order)) {
> 
> I can do the change while applying...

Thanks and pleas do.

-- 
Kind Regards,
Niklas Söderlund




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux