On Sun, Dec 08, 2024 at 10:19:51PM +0100, Ricardo Ribalda Delgado wrote: > > > + state = v4l2_subdev_get_locked_active_state(&imx214->sd); > > > > Sakari, I see that other drivers assume that the active is locked in > > set_ctrl. Is this correct? > > imx214->sd.state_lock = imx214->ctrls.lock; > > So I guess it is fine :) Yes, it is. Please also run this on the set: $ ./scripts/checkpatch.pl --strict --max-line-length=80 -- Sakari Ailus