Re: [PATCH] media: ccs: Print a warning on CCS static data parse failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

On Mon, Dec 09, 2024 at 11:40:00AM +0000, Sakari Ailus wrote:
> Hi Mehdi,
> 
> On Mon, Dec 09, 2024 at 12:17:38PM +0100, Mehdi Djait wrote:
> > ccs_data_parse() return value is not propagated up to the probe
> > function, making it difficult on static data parse Failure.
> 
> Could you reword this by referring to the CCS static data library only?
> This would fit better for the CCS tools where the patch will also be
> imported to.
> 
> <URL:https://github.com/MIPI-Alliance/ccs-tools>
> 
> I also wonder if the CCS driver should actually fail probe if parsing
> fails: this is a very likely problem and quitting there would be
> appropriate IMO. Not every device might need one, so it should be just
> based on parser failure.

I would also think there is no point to continue probing if parsing fails. I
will send a v2 for this.

--
Kind Regards
Mehdi Djait




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux