Hi,
On 14-Nov-24 8:10 PM, Ricardo Ribalda wrote:
> Do not process unknown data types.
>
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> ---
> drivers/media/usb/uvc/uvc_v4l2.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c
> index 5000c74271e0..4c88dab15554 100644
> --- a/drivers/media/usb/uvc/uvc_v4l2.c
> +++ b/drivers/media/usb/uvc/uvc_v4l2.c
> @@ -106,6 +106,12 @@ static int uvc_ioctl_xu_ctrl_map(struct uvc_video_chain *chain,
> struct uvc_control_mapping *map;
> int ret;
>
> + if (xmap->data_type > UVC_CTRL_DATA_TYPE_BITMASK) {
> + uvc_dbg(chain->dev, CONTROL,
> + "Unsupported UVC data type %u\n", xmap->data_type);
> + return -ENOTTY;
This seems like a textbook case for -EINVAL ?
Otherwise patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Regards,
Hans
> + }
> +
> map = kzalloc(sizeof(*map), GFP_KERNEL);
> if (map == NULL)
> return -ENOMEM;
>
