Hi Bryan,
On 12/6/2024 8:14 AM, Bryan O'Donoghue wrote:
Re: [PATCH 15/16] media: qcom: camss: Add CSID 780 support for sm8550
Please drop sm8550 in your patch title, change it to something more
consistent with the VFE patch title i.e. your next patch.
Sure, will drop sm8550 in the title.
+++ b/drivers/media/platform/qcom/camss/camss-csid-780.h
@@ -0,0 +1,25 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * camss-csid-780.h
+ *
+ * Qualcomm MSM Camera Subsystem - CSID (CSI Decoder) Module
Generation 3
+ *
+ * Copyright (c) 2024 Qualcomm Technologies, Inc.
+ */
+#ifndef QC_MSM_CAMSS_CSID_780_H
+#define QC_MSM_CAMSS_CSID_780_H
#ifndef __CAMSS_CSID_780_H__ or __QC_MSM_CAMSS_CSID_780_H__
Either way please encapsulate your guard __thus__
Same comment for all new headers added in this series.
Thanks for the comments, I will check the other headers in this series
and update them based on suggestion.
Thanks,
Depeng
