Re: [PATCH 11/16] dt-bindings: media: camss: Add qcom,sm8550-camss binding

[Depeng Shao <quic_depengs@xxxxxxxxxxx>]

Hi Bryan,

On 12/6/2024 12:11 AM, Bryan O'Donoghue wrote:
> On 05/12/2024 15:55, Depeng Shao wrote:
> > +            iommus = <&apps_smmu 0x800 0x20>;
>
> This iommu list looks a bit spartan.
>
> Here's what I have for X1E:
>
> https://git.codelinaro.org/bryan.odonoghue/kernel/-/ 
> commit/9686eaf9557c386a2525d6668da6fe24ffd518c4#5b6ff684e5292a4c0b51f6a38631777fafae7561_4749_4874
>
> Could you double check this list ?

Since the camss driver just support ife, so I think only ife related 
iommus are needed, just like we don't add ipe,bps,jpeg related clk and 
register in the dt-binding.

	msm_cam_smmu_ife { 
 

		compatible = "qcom,msm-cam-smmu-cb"; 
 

		iommus = <&apps_smmu 0x800 0x20>;
		......
	};

> ---
> bod


Thanks,
Depeng