Hi Tomi, On Dec 04, 2024 at 13:05:14 +0200, Tomi Valkeinen wrote: > This series fixes various small issues in the drivers, and adds a few > things (a couple of pixel formats and a debugging feature). > > It also takes a few steps in adding more i2c read/write error handlings > to the drivers, but covers only the easy places. > > Adding error handling to all reads/writes needs more thinking, perhaps > adding a "ret" parameter to the calls, similar to the cci_* functions, > or perhaps adding helpers for writing multiple registers from a given > table. Also, in some places rolling back from an error will require > work. > With the minor comment addressed, for the series: Reviewed-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> > --- > Changes in v3: > - Include bitfield.h for FIELD_PREP() > - Cc stable for relevant fixes > - Link to v2: https://lore.kernel.org/r/20241108-ub9xx-fixes-v2-0-c7db3b2ad89f@xxxxxxxxxxxxxxxx > > Changes in v2: > - Address comments from Andy > - Add two new patches: > - media: i2c: ds90ub960: Fix shadowing of local variables > - media: i2c: ds90ub960: Use HZ_PER_MHZ > - Link to v1: https://lore.kernel.org/r/20241004-ub9xx-fixes-v1-0-e30a4633c786@xxxxxxxxxxxxxxxx > > --- > Tomi Valkeinen (15): > media: i2c: ds90ub9x3: Fix extra fwnode_handle_put() > media: i2c: ds90ub960: Fix UB9702 refclk register access > media: i2c: ds90ub960: Fix use of non-existing registers on UB9702 > media: i2c: ds90ub960: Fix logging SP & EQ status only for UB9702 > media: i2c: ds90ub960: Fix UB9702 VC map > media: i2c: ds90ub960: Use HZ_PER_MHZ > media: i2c: ds90ub960: Add support for I2C_RX_ID > media: i2c: ds90ub960: Add RGB24, RAW8 and RAW10 formats > media: i2c: ds90ub953: Clear CRC errors in ub953_log_status() > media: i2c: ds90ub960: Drop unused indirect block define > media: i2c: ds90ub960: Reduce sleep in ub960_rxport_wait_locks() > media: i2c: ds90ub960: Handle errors in ub960_log_status_ub960_sp_eq() > media: i2c: ds90ub913: Add error handling to ub913_hw_init() > media: i2c: ds90ub953: Add error handling for i2c reads/writes > media: i2c: ds90ub960: Fix shadowing of local variables > > drivers/media/i2c/ds90ub913.c | 26 ++++-- > drivers/media/i2c/ds90ub953.c | 56 +++++++++---- > drivers/media/i2c/ds90ub960.c | 186 ++++++++++++++++++++++++++++-------------- > 3 files changed, 187 insertions(+), 81 deletions(-) > --- > base-commit: adc218676eef25575469234709c2d87185ca223a > change-id: 20241004-ub9xx-fixes-bba80dc48627 > > Best regards, > -- > Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> > -- Thanks, Jai
Attachment:
signature.asc
Description: PGP signature
