Hi Joe,
On Thu, 05 Dec 2024 11:06:21 +0900, Joe Hattori wrote:
> In allegro_probe(), the v4l2 device is not unregistered in the error
> path, which results in a memory leak. Fix it by calling
> v4l2_device_unregister() before returning error.
Thanks for the patch!
Out of curiosity: How did you find the memory leak? Did you use some
specific tooling for that?
>
> Fixes: d74d4e2359ec ("media: allegro: move driver out of staging")
> Signed-off-by: Joe Hattori <joe@xxxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx>
> ---
> drivers/media/platform/allegro-dvt/allegro-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/allegro-core.c
> index e491399afcc9..eb03df0d8652 100644
> --- a/drivers/media/platform/allegro-dvt/allegro-core.c
> +++ b/drivers/media/platform/allegro-dvt/allegro-core.c
> @@ -3912,6 +3912,7 @@ static int allegro_probe(struct platform_device *pdev)
> if (ret < 0) {
> v4l2_err(&dev->v4l2_dev,
> "failed to request firmware: %d\n", ret);
> + v4l2_device_unregister(&dev->v4l2_dev);
> return ret;
> }
>
> --
> 2.34.1
>
>
