Hi Jacopo, On Wed, Dec 04, 2024 at 12:33:28PM +0100, Jacopo Mondi wrote: > Hi Sakari > > On Fri, Nov 29, 2024 at 11:51:40AM +0200, Sakari Ailus wrote: > > Add V4L2_CID_BINNING control for configuting binning and enumerating a > > camera sensor's binning capabilities. The control combines horizontal and > > vertical binning into a single control as the two are generally related. > > > > New drivers should use this control to configure binning. > > I thought the idea was to post-pone this (and the following 2 patches) > to when controls will be able to be tested without changing the device > configuration, to properly support TRY_FORMAT, and before that time > work with selection rectangles and let the drivers select the > "correct" binning/scaling factors deduced from the > TGT_CROP-to-TGT_COMPOSE ratio on (pad, stream) 1/0 As I wrote on the cover letter, some of the patches in the set will likely be postponed. Most likely this will mean the binning and sub-sampling control patches. I still wanted to include them so we'd give some view on how this would look like once we have control values in sub-device state. -- Kind regards, Sakari Ailus