Hi, On 29-Nov-24 4:17 PM, Xiong Nandi wrote: > uvc_query_name was introduced to print query name in uvc_query_ctrl. > So we can also use it in uvc_get_video_ctrl. > > Signed-off-by: Xiong Nandi <xndchn@xxxxxxxxx> Thank you for your patch. I have merged this into: https://gitlab.freedesktop.org/linux-media/users/uvc/-/commits/next/ with the line-wrapping fixed to 80 chars. Regards, Hans > --- > drivers/media/usb/uvc/uvc_video.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c > index e00f38dd07d9..93cacd2c8721 100644 > --- a/drivers/media/usb/uvc/uvc_video.c > +++ b/drivers/media/usb/uvc/uvc_video.c > @@ -297,8 +297,8 @@ static int uvc_get_video_ctrl(struct uvc_streaming *stream, > goto out; > } else if (ret != size) { > dev_err(&stream->intf->dev, > - "Failed to query (%u) UVC %s control : %d (exp. %u).\n", > - query, probe ? "probe" : "commit", ret, size); > + "Failed to query (%s) UVC %s control : %d (exp. %u).\n", > + uvc_query_name(query), probe ? "probe" : "commit", ret, size); > ret = (ret == -EPROTO) ? -EPROTO : -EIO; > goto out; > }
