Hi Matthias, Krzysztof,
On 12/2/24 08:56, Krzysztof Kozlowski wrote:
> On Sat, Nov 30, 2024 at 03:17:15PM +0100, Matthias Fend wrote:
>> The imx415 driver expects a clock with the name "inck".
>> Document this in the bindings.
>
> No, fix the driver instead of bypassing review. It was decided to drop
> it during review, so you cannot reintroduce it 2 years later claiming
> that's now ABI. Of course original submission was buggy and never
> tested, but that does not allow review bypass.
Just to make sure I am on the same page here: Between v2 and v3 of the
IMX415 submission the clock-names property was dropped. At that point,
we should have changed the acquisition of the clock from
sensor->clk = devm_clk_get(sensor->dev, "inck");
to
sensor->clk = devm_clk_get(sensor->dev, NULL);
Is that correct/the proper fix?
>
> Best regards,
> Krzysztof
>
Best regards,
Michael
