On Thu, 28 Nov 2024 at 22:27, Jani Nikula <jani.nikula@xxxxxxxxx> wrote: > On Thu, 28 Nov 2024, Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote: > > We used to have a low bar for entry on our past multi-committers > > model (back in 2005-2007). It was a disaster, as one of the > > committer did very evil things. He was blocked, but that didn't > > prevent some of us to be threatened with physical violence - and > > some people even reported death threats. > > While I understand the hesitation, I don't think it's fair towards > potential future collaborators to distrust them based on a bad actor > from nearly 20 years ago. Yeah this sounds a lot more like a CoC issue (which of course could result in a very swift removal of commit rights and suspend from all access to gitlab and mailing lists). Aside from reference the CoC we've left these things out of scope of the commit rights processes and merge criteria. My key takeaway over the last decade more of maintainering is that assuming that people want to do the right thing and building a process optimized for that works really well. And then handle the toxic people entirely separately through solid conduct enforcement. > >> Frankly, I'm not fond of the invite-only model. You need to be careful > >> to not lose transparency. > > > > The intent is to be as transparent as possible without violating regulations > > like GPDR. > > I have no idea how GDPR would be relevant here. We don't collect data, > other than what's in git. Yeah I don't see the GDPR connection either. > >> I think it's also important to define merge criteria. A set of rules by > >> which a committer can commit. And it's not really about technical > >> checkboxes. For example, in drm it really boils down to two things: at > >> least two people have been involved, and there are no open issues. > > > > That's the same criteria we're aiming for. We'll start without > > two people reviewing, as there won't be enough committers at the > > It's not two reviewers for us either; it's typically author+reviewer and > either author or reviewer commits. Two sets of eyeballs in total. > > > beginning for that, but maintainers may revert/rebase the tree in > > case they don't agree with changes. > > Not sure if you really mean it, but saying it like that doesn't really > breed trust, IMO. Sure, there have been patches merged to i915 that I > didn't "agree" with. But bad enough to warrant a revert? Very few and > far between, and always for clear and concrete reasons rather than > anything subjective. > > Side note, we don't do rebases in the development branches. Yeah, if I don't forget anything I remember a grand total of three rebases by maintainers, and this over 8 years or so of doing this: - Someone pushed their entire development tree by accident. We obviously had to back that out and improved the tooling to catch these better. - Someone who pushed an entire pile of work (I think 30 patches or so) that missed the merge window into -fixes for a late -rc1. - Someone who lost trust with upstream maintainers because they refused to listen for way too long to engineering direction and consensus. The last big push of development work was backed out again. There might have been some other things, but I think those were more maintainers screwing things up than committers pushing stuff, and on trees that are handled with the more classic group maintainer model. It's really an extremely rare event that we rebase out patches. Reverts are usually handled like any other patches with the usual test and review flow, just hopefully a bit accelerated. Cheers, Sima > > Currently, for most of the drivers, the number of committers per driver > > is equal to the number of maintainers for the same driver. > > FWIW, I think that pretty much matches how it was for most drivers in > drm before the committer model. > > > So, on this stage, we're aiming on get maintainers commit rights, > > starting with the ones that are long time contributors and regularly > > participate at the media summits. > > > > Once the "slow start" phase finishes, we can review the process and > > start thinking on getting more developers and committers. > > Just saying, it's easier to convince people to become committers with no > strings attached than (co-)maintainers with a bunch of responsibilities, > such as review or travel obligations. -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
