On 11/27/24 12:01, Yassine Oudjana wrote:
On 22/11/2024 5:06 am, Barnabás Czémán wrote:
Fix NULL pointer check before device_link_del
is called.
The intention is clear, but the context of the change is completely lost.
Fixes: eb73facec2c2 ("media: qcom: camss: Use common VFE pm_domain_on/pm_domain_off where applicable")
It's invalid, the change is not a fix.
Signed-off-by: Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx>
---
drivers/media/platform/qcom/camss/camss-vfe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
base-commit: decc701f41d07481893fdea942c0ac6b226e84cd
change-id: 20241122-vfe_pm_domain_off-c57008e54167
Best regards,
diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
index 80a62ba11295042802cbaec617fb87c492ea6a55..1bf1473331f63b9ab106d21ea263c84d851c8a31 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe.c
@@ -595,7 +595,7 @@ void vfe_isr_reset_ack(struct vfe_device *vfe)
*/
void vfe_pm_domain_off(struct vfe_device *vfe)
{
- if (!vfe->genpd)
+ if (!vfe->genpd_link)
return;
device_link_del(vfe->genpd_link);
Tested-by: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
The change is useless and it shall be dropped.
--
Best wishes,
Vladimir
