On 26/11/2024 10:58, Renjiang Han wrote: > > On 11/26/2024 5:34 PM, Krzysztof Kozlowski wrote: >> On 26/11/2024 09:57, Renjiang Han wrote: >>>>> +description: >>>>> + The Venus IP is a video encode and decode accelerator present >>>>> + on Qualcomm platforms >>>>> + >>>>> +allOf: >>>>> + - $ref: qcom,venus-common.yaml# >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + const: qcom,qcs615-venus >>>> Please extend sc7180-venus.yaml instead. No need to duplicate >>>> unnecessary things. >>> Thanks for your review. But I'm sorry I can't get it. The devicetree for >>> >>> qcs615-venus is in qcs615.dtsi. I'm not sure how to use sc7180-venus.yaml >>> >>> instead. >> DTSI is not relevant here to the bindings. I don't understand the >> problem, so not sure what you are asking here about. > The opp-table parameters are different in devicetree. Can we also use > the same yaml file? Please look at existing bindings for other devices. Best regards, Krzysztof
