Refactor the camss_link_entities function by breaking it down into three distinct functions. Each function will handle the linking of a specific entity separately. SC7280 and later targets mandates for 1:1 linking for csid -> vfe. i.e. csid0 can be mapped to vfe0 only. Changes in V4: - removed null check from camss_link_err. - Link to v3: https://lore.kernel.org/lkml/20241125103457.1970608-3-quic_vikramsa@xxxxxxxxxxx/ Changes in V3: - Broke down the change in 2 patches. first one to functionally decompose link error message. second to restrcture the link function. - Removed the declarion of camss_link_error from header file. - Link to v2: https://lore.kernel.org/linux-arm-msm/20241112133846.2397017-1-quic_vikramsa@xxxxxxxxxxx/ Changes in V2: - Declared variables in reverse christmas tree order. - Functionally decomposed link error message. - Link to v1: https://lore.kernel.org/linux-arm-msm/20241111173845.1773553-1-quic_vikramsa@xxxxxxxxxxx/ To: Robert Foss <rfoss@xxxxxxxxxx> To: Todor Tomov <todor.too@xxxxxxxxx> To: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> Cc: linux-media@xxxxxxxxxxxxxxx Cc: linux-kernel@xxxxxxxxxxxxxxx Signed-off-by: Vikram Sharma <quic_vikramsa@xxxxxxxxxxx> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> Vikram Sharma (2): media: qcom: camss: reducing the repitious error message string media: qcom: camss: Restructure camss_link_entities drivers/media/platform/qcom/camss/camss.c | 193 ++++++++++++++-------- 1 file changed, 128 insertions(+), 65 deletions(-) -- 2.25.1
