On Mon, 25 Nov 2024 at 07:31, Renjiang Han (QUIC) <quic_renjiang@xxxxxxxxxxx> wrote: > On Saturday, November 23, 2024 8:17 AM, Bryan O'Donoghue wrote: > > On 23/11/2024 00:05, Dmitry Baryshkov wrote: > > > This leaves sm7150, sm8150 and sm8450 untouched. Don't they also need > > > to use HW_CTRL_TRIGGER? > > > I believe the correct list here is anything that is HFI_VERSION_4XX in > > > You can't apply the second patch in this series without ensuring the clock controllers for sdm845 and sm7180 > > > grep HFI_VERSION_4XX drivers/media/platform/qcom/venus/core.c > > > drivers/clk/qcom/videocc-sdm845.c > > drivers/clk/qcom/videocc-sc7180.c > > > Hmm.. that's what this patch does, to be fair my other email was flippant. > > > This is fine in general, once we can get some Tested-by: for it. > > > That's my question - what platforms has this change been tested on ? > > > I can do sdm845 but, we'll need to find someone with 7180 to verify IMO. > > Thanks for your comment. We have run video case with these two patches on sc7180. The result is fine. A single case, a thorough tests, a mixture of suspend&resume while playing video cases? Also, can I please reiterate my question: sm7150, sm8150 and sm8450 ? Should they also be changed to use HW_CTRL_TRIGGER? Next question, sdm660, msm8996, msm8998: do they support HW_CTRL_TRIGGER? -- With best wishes Dmitry
