On 25/11/2024 09:06, Renjiang Han (QUIC) wrote: > On Monday, November 25, 2024 2:38 PM, Rob Herring (Arm) wrote: >> On Mon, 25 Nov 2024 11:04:49 +0530, Renjiang Han wrote: >>> Add support for Qualcomm video acceleration hardware used for video >>> stream decoding and encoding on QCOM QCS615. >>> >>> Signed-off-by: Renjiang Han <quic_renjiang@xxxxxxxxxxx> >>> --- >>> .../bindings/media/qcom,qcs615-venus.yaml | 182 +++++++++++++++++++++ >>> 1 file changed, 182 insertions(+) >>> > >> My bot found errors running 'make dt_binding_check' on your patch: > >> yamllint warnings/errors: > >> dtschema/dtc warnings/errors: >> Documentation/devicetree/bindings/media/qcom,qcs615-venus.example.dts:25:18: fatal error: dt-bindings/clock/qcom,qcs615-videocc.h: No such file or directory >> 25 | #include <dt-bindings/clock/qcom,qcs615-videocc.h> >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> compilation terminated. >> make[2]: *** [scripts/Makefile.dtbs:129: Documentation/devicetree/bindings/media/qcom,qcs615-venus.example.dtb] Error 1 >> make[2]: *** Waiting for unfinished jobs.... >> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2 >> make: *** [Makefile:224: __sub-make] Error 2 > > Thanks for your reply. "dt-bindings/clock/qcom,qcs615-videocc.h" has been added in https://lore.kernel.org/all/20241108-qcs615-mm-clockcontroller-v3-0-7d3b2d235fdf@xxxxxxxxxxx/. Why do you ignore rest of the email? > >> doc reference errors (make refcheckdocs): > >> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241125-add-venus-for-qcs615-v3-1-5a376b97a68e@xxxxxxxxxxx > >> The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. Read, here. Best regards, Krzysztof