Hi Krzysztof,
On Fri, Nov 22, 2024 at 2:01 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 21/11/2024 22:05, Jiasheng Jiang wrote:
> > Add check for the return value of clk_enable() to gurantee the success.
> >
> > Fixes: b5f1220d587d ("[media] v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers")
> > Signed-off-by: Jiasheng Jiang <jiashengjiangcool@xxxxxxxxx>
> > ---
> > drivers/media/platform/samsung/exynos4-is/mipi-csis.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
> > index 63f3eecdd7e6..d1c938065475 100644
> > --- a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
> > +++ b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
> > @@ -940,7 +940,9 @@ static int s5pcsis_pm_resume(struct device *dev, bool runtime)
> > state->supplies);
> > goto unlock;
> > }
> > - clk_enable(state->clock[CSIS_CLK_GATE]);
> > + ret = clk_enable(state->clock[CSIS_CLK_GATE]);
> > + if (ret)
> > + goto unlock;
>
> You should unwind the work done, so power off the phy and disble regulators.
Thank you for your advice. I will submit a v2 patch.
Additionally, I noticed a redundant space before the label "unlock," so I will
remove it as well.
-Jiasheng
