Hi Dheeraj
On Tue, Nov 19, 2024 at 11:32:20AM +0530, Dheeraj Reddy Jonnalagadda wrote:
> This commit fixes an unused value issue detected by Coverity (CID
> 1519008). The error condition for the invalid MIPI CSI-2 is not
> properly handled as the break statement would only exit the switch block
> and not the entire loop. Fixed this by returning the error immediately
> after the switch block.
>
> Fixes: 7d4f126fde89 ("media: rkisp1: Make the internal CSI-2 receiver
> optional")
>
> Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@xxxxxxxxx>
Reviewed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
(if you receive a tag on a previous version of the patch you should
carry it forward to the next patch version ;)
Thanks
j
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> index dd114ab77800..9ad5026ab10a 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> @@ -228,6 +228,9 @@ static int rkisp1_subdev_notifier_register(struct rkisp1_device *rkisp1)
> break;
> }
>
> + if (ret)
> + break;
> +
> /* Parse the endpoint and validate the bus type. */
> ret = v4l2_fwnode_endpoint_parse(ep, &vep);
> if (ret) {
> --
> 2.34.1
>
>
