Hi, Shu-hsiang:
On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces utility files for the MediaTek ISP7.x camsys driver. These
> utilities provide essential platform definitions, debugging tools, and
> management functions to support ISP operations and SCP communication.
> Key functionalities include:
> 1.Hardware pipeline and register definitions for managing image
> processing modules.
> 2.DMA debugging utilities and buffer management functions.
> 3.Definitions of supported image formats for proper data handling.
> 4.IPI and SCP communication structures for module state management and
> configuring ISP.
> 5.Metadata parameters for configuring image processing.
>
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@xxxxxxxxxxxx>
> ---
[snip]
> +static void vb2_sync_for_device(void *buf_priv)
> +{
> + struct mtk_cam_vb2_buf *buf = buf_priv;
> + struct sg_table *sgt = buf->dma_sgt;
I could not find anywhere to use struct mtk_cam_vb2_buf and set buf->dma_sgt.
I think buf_priv is set by vb2 framework.
Follow the standard vb2 framework to sync for device. (Maybe the vb2 framework already do this)
And drop struct mtk_cam_vb2_buf{}.
Regards,
CK
> +
> + if (!sgt)
> + return;
> +
> + dma_sync_sgtable_for_device(buf->dev, sgt, buf->dma_dir);
> +}
> +
